Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Test on Linux arm64 runners #3778

Merged
merged 10 commits into from
Feb 6, 2025
Merged

CI: Test on Linux arm64 runners #3778

merged 10 commits into from
Feb 6, 2025

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 18, 2025

@seisman seisman added the maintenance Boring but important stuff for the core devs label Jan 18, 2025
@weiji14
Copy link
Member

weiji14 commented Jan 22, 2025 •
edited
Loading

Test failures on some x2sys_cross tests appear to be the same as #3194, we had some logic to handle the shape mismatches using an if sys.platform == "darwin" check, e.g. here:

https://github.com/GenericMappingTools/pygmt/blob/8a09f75cae034ab0e01e1a29e46df65a116d9508/pygmt/tests/test_x2sys_cross.py#L273-277

Maybe we can use if platform.machine() == "arm64" to handle both Ubuntu and macOS arm64 variants, xref https://docs.python.org/3/library/platform.html#platform.machine?

@seisman
Copy link
Member Author

seisman commented Jan 26, 2025

Maybe we can use if platform.machine() == "arm64" to handle both Ubuntu and macOS arm64 variants, xref https://docs.python.org/3/library/platform.html#platform.machine?

platform.machine() returns arm64 on macOS ARM and aarch64 on Linux ARM. So, if platform.machine() in {"aarch64", "arm64"}: works, but there are still two failures related to contour.

@seisman
Copy link
Member Author

seisman commented Feb 3, 2025

Maybe we can use if platform.machine() == "arm64" to handle both Ubuntu and macOS arm64 variants, xref https://docs.python.org/3/library/platform.html#platform.machine?

platform.machine() returns arm64 on macOS ARM and aarch64 on Linux ARM. So, if platform.machine() in {"aarch64", "arm64"}: works, but there are still two failures related to contour.

I've marked the two 'contour' tests as xfail on Linux ARM and now all tests pass.

@seisman seisman added this to the 0.15.0 milestone Feb 3, 2025
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 3, 2025
@seisman seisman merged commit e9792fe into main Feb 6, 2025
22 checks passed
@seisman seisman deleted the ci/linux-arm branch February 6, 2025 23:21
@seisman seisman removed the needs review This PR has higher priority and needs review. label Feb 6, 2025
weiji14 added a commit that referenced this pull request Feb 10, 2025
@weiji14
CI: Use matrix.os instead of runner.os in artifact name
58b46a9 
Fixes error `Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run` on the ubuntu-24.04-arm job. Patches #3778
@weiji14 weiji14 mentioned this pull request Feb 10, 2025
Merged
6 tasks
weiji14 added a commit that referenced this pull request Feb 10, 2025
@weiji14 @seisman
CI: Use matrix.os instead of runner.os in artifact name (#3797)
21a2ae5 
Fixes error `Failed to CreateArtifact: Received non-retryable error:
Failed request: (409) Conflict: an artifact with this name already exists
on the workflow run` on the ubuntu-24.04-arm job. Patches #3778

---------

Co-authored-by: Dongdong Tian <[email protected]>
@seisman seisman mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @weiji14